Prefix any unused method arguments with an underscore

github · Watemlifts · Dec 23, 2021 · Jan 21, 2022 · Feb 27, 2022 · Feb 27, 2022
commit b6d22ec78bd66042d9bd5f6ce9619225ce56a81c
diff --git a/lib/scientist/experiment.rb b/lib/scientist/experiment.rb
@@ -130,7 +130,7 @@ def clean_value(value)
   # and return true or false.
   #
   # Returns the block.
-  def compare(*args, &block)
+  def compare(*_args, &block)
     @_scientist_comparator = block
   end
 
@@ -140,7 +140,7 @@ def compare(*args, &block)
   # and return true or false.
   #
   # Returns the block.
-  def compare_errors(*args, &block)
+  def compare_errors(*_args, &block)
     @_scientist_error_comparator = block
   end
 
@@ -202,7 +202,7 @@ def raise_with(exception)
   # Called when an exception is raised while running an internal operation,
   # like :publish. Override this method to track these exceptions. The
   # default implementation re-raises the exception.
-  def raised(operation, error)
+  def raised(_operation, error)
     raise error
   end
 

diff --git a/test/scientist/experiment_test.rb b/test/scientist/experiment_test.rb
@@ -149,7 +149,7 @@ def ex.enabled?
       true
     end
 
-    def ex.publish(result)
+    def ex.publish(_result)
       raise "boomtown"
     end
 
@@ -164,7 +164,7 @@ def ex.publish(result)
   end
 
   it "reports publishing errors" do
-    def @ex.publish(result)
+    def @ex.publish(_result)
       raise "boomtown"
     end