Automatically wait for retries in gh eval
#75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds automatic retry functionality for rate-limited requests in the gh eval command. The implementation listens for rate limit headers and waits for the specified duration before retrying.
- Introduces a new
RateLimitErrortype with retry timing information - Adds automatic retry logic in the evaluation command with configurable wait times
- Refactors model calling logic to support retry functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/azuremodels/azure_client.go | Adds rate limit error handling and RateLimitError type definition |
| internal/azuremodels/rate_limit_test.go | Comprehensive test coverage for rate limit error handling logic |
| cmd/eval/eval.go | Implements retry logic with automatic waiting and refactors model calling |
sgoedecke
force-pushed
the
sgoedecke/eval-retries
branch
from
ff4d73e to
e618ed9
Compare
jalafel
approved these changes
Jul 21, 2025
sgoedecke
force-pushed
the
sgoedecke/eval-retries
branch
from
b7ae777 to
ffabf58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
gh evalto listen for theretry-afterandx-retry-timeremainingheaders and automatically wait.If we can't read either of those headers, we just wait for a minute.