Skip to content

Add a --json mode to evals #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgoedecke merged 6 commits into from
Jun 5, 2025
Merged

Add a --json mode to evals #55

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0ae63f6
Add docs link and remove unneeded type
sgoedecke Jun 5, 2025
0b65416
JSON mode for evals
sgoedecke Jun 5, 2025
53887d6
go fmt
sgoedecke Jun 5, 2025
eecd38f
Refactor out BuildChatCompletionOptions
sgoedecke Jun 5, 2025
b2cb120
Refactor out message role function
sgoedecke Jun 5, 2025
41f4662
Add docs to readme and fixup pass rate logic
sgoedecke Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add docs link and remove unneeded type
  • Loading branch information
@sgoedecke
sgoedecke committed Jun 5, 2025
commit 0ae63f6cb71699485befeb894e687725cf2c0683
10 changes: 4 additions & 6 deletions cmd/eval/eval.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ import (
"github.com/spf13/cobra"
)

// EvaluationPromptFile represents the structure of a prompt.yml file for evaluation
// It extends the base prompt.File with evaluation-specific fields
type EvaluationPromptFile = prompt.File

// TestResult represents the result of running a test case
type TestResult struct {
TestCase map[string]interface{} `json:"testCase"`
Expand Down Expand Up @@ -61,6 +57,8 @@ func NewEvalCommand(cfg *command.Config) *cobra.Command {
- name: contains-hello
string:
contains: "hello"

See https://docs.github.com/github-models/use-github-models/storing-prompts-in-github-repositories#supported-file-format for more information.
`),
Example: "gh models eval my_prompt.prompt.yml",
Args: cobra.ExactArgs(1),
Expand Down Expand Up @@ -90,10 +88,10 @@ func NewEvalCommand(cfg *command.Config) *cobra.Command {
type evalCommandHandler struct {
cfg *command.Config
client azuremodels.Client
evalFile *EvaluationPromptFile
evalFile *prompt.File
}

func loadEvaluationPromptFile(filePath string) (*EvaluationPromptFile, error) {
func loadEvaluationPromptFile(filePath string) (*prompt.File, error) {
evalFile, err := prompt.LoadFromFile(filePath)
if err != nil {
return nil, fmt.Errorf("failed to load prompt file: %w", err)
Expand Down