Skip to content

Move conversion of PR diff-range paths to absolute paths #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaspersv wants to merge 4 commits into
base: main
Choose a base branch
from
+336 −100
Open

Move conversion of PR diff-range paths to absolute paths #3248

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
035c117
upload-lib: Unit test filterAlertsByDiffRange
kaspersv Oct 28, 2025
d18f3ac
Move diff-range extension pack generation into testable function
kaspersv Oct 28, 2025
df4e199
Add unit test for diffRangeExtensionPackContents
kaspersv Oct 28, 2025
4eb2475
Move conversion of PR diff-range paths to absolute paths
kaspersv Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add unit test for diffRangeExtensionPackContents
  • Loading branch information
@kaspersv
kaspersv committed Nov 12, 2025
commit df4e1992c04acc62081ad2561c9e3bc375e8e6d8
17 changes: 17 additions & 0 deletions src/analyze.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
defaultSuites,
resolveQuerySuiteAlias,
addSarifExtension,
diffRangeExtensionPackContents,
} from "./analyze";
import { createStubCodeQL } from "./codeql";
import { Feature } from "./feature-flags";
Expand Down Expand Up @@ -158,3 +159,19 @@ test("addSarifExtension", (t) => {
);
}
});

test("diffRangeExtensionPackContents", (t) => {
const output = diffRangeExtensionPackContents([
{
path: "/checkout/path/main.js",
startLine: 10,
endLine: 20,
},
]);

const expected = fs.readFileSync(
`${__dirname}/../src/testdata/pr-diff-range.yml`,
"utf8",
);
t.deepEqual(output, expected);
});
8 changes: 8 additions & 0 deletions src/testdata/pr-diff-range.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@

extensions:
- addsTo:
pack: codeql/util
extensible: restrictAlertsTo
checkPresence: false
data:
- ['/checkout/path/main.js', 10, 20]