-
Notifications
You must be signed in to change notification settings - Fork 430
Perform SARIF post-processing independently of upload #3222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
489ed91
Split SARIF post-processing steps from `uploadSpecifiedFiles` into a …
mbg 6fbdd5f
Split SARIF uploading steps from `uploadSpecifiedFiles` into a function
mbg 899bf2f
Use `postProcessSarifFiles` and `uploadProcessedFiles` in `uploadSarif`
mbg 596de7f
Move `UploadKind` check into `uploadSarif`
mbg 14139c9
Add test for `uploadSarif` with `upload: never`
mbg c2bec36
Add `post-process-output` input to `analyze` action
mbg 12f3cfe
Write processed SARIF files if `post-process-output` input is provided
mbg def04c1
Add test for `uploadSarif` with output directory
mbg 5e37670
Use `post-process-output` in PR check
mbg d79c0a1
Fix incomplete comment
mbg 89d3359
Improve test name
mbg 6f0fcbe
Rename `uploadSarif`
mbg 8ff870a
Rename new input to `processed-sarif-path`
mbg aed27f7
Fix linter issue
mbg f48b54a
Fix fallback not being guarded by `uploadKind` check
mbg b9cd368
Merge remote-tracking branch 'origin/main' into mbg/upload-lib/post-p…
mbg f0452d5
Consistently use "post-processing"
mbg 710606c
Check that `outputPath` is non-empty
mbg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add
post-process-output input to analyze action
- Loading branch information
commit c2bec36917d1974b9f0efdc8d1047453900f6a0a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the order of these input declarations chosen strongly based on discoverability for the user? If not, then I'd like this to be right next to the
outputinput declared near the top in the name of coherence.Second, and I'm sorry if this naming has been discussed at length in related PRs earlier:
post-process-outputreads like a boolean toggle, not a path.post-processed-outputsounds more like a path. Additionally we always do the post-processing regardless of wether we save them to disk..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this would be a better name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ironically, I think this kind of bad naming is actually something I complained about on
@redsun82's PR previously, which he then changed to something better. I agree that this isn't a good name and have changed it toprocessed-sarif-pathfor now. That makes it consistent with otherpathinputs (other thanoutputhere). I don't think think thatpost-processed-outputis really any better thanpost-process-output.Generally, I think the order is roughly based on how relevant the input is to a user. (See e.g. that we have the ones that are automatically populated or used internally only at the bottom.)