C/C++ overlay: Discard xml entities #21017
Merged
+50
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IdrissRio
force-pushed
the
idrissrio/cpp/overlay/xml
branch
from
0243e2b to
84bbe71
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for discarding XML entities in C++ overlay analysis by introducing a new OverlayXml.qll module that follows the established pattern used in other CodeQL languages.
- Introduces
OverlayXml.qllwith predicates to identify and discard XML entities from the overlay base - Integrates the new module into the existing
Overlay.qllinfrastructure
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cpp/ql/lib/semmle/code/cpp/internal/OverlayXml.qll | New module implementing XML entity discard logic for overlay analysis, identical to implementations in other languages |
| cpp/ql/lib/semmle/code/cpp/internal/Overlay.qll | Imports the new OverlayXml module to enable XML entity discarding |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
You'll need to update codeql/config/identical-files.json Line 280 in e13bb0f |
jketema
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for discarding XML entities in C++ overlay analysis.
It introduces
OverlayXml.qllfollowing the same approach as other languages, e.g., Java, C#, Javascript etc.