Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(browser): Refactor type casts of browser metrics #14542

Merged
merged 6 commits into from
Dec 11, 2024
Merged

ref(browser): Refactor type casts of browser metrics #14542

merged 6 commits into from
Dec 11, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 2, 2024

Get rid of some type casts around browser timing events/metrics capture.

@mydea mydea self-assigned this Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.27 KB - -
@sentry/browser - with treeshaking flags 21.94 KB - -
@sentry/browser (incl. Tracing) 35.77 KB +0.07% +22 B 🔺
@sentry/browser (incl. Tracing, Replay) 73 KB +0.03% +19 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.4 KB +0.03% +19 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 77.31 KB +0.03% +18 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.8 KB +0.03% +21 B 🔺
@sentry/browser (incl. Feedback) 40.02 KB - -
@sentry/browser (incl. sendFeedback) 27.88 KB - -
@sentry/browser (incl. FeedbackAsync) 32.67 KB - -
@sentry/react 25.94 KB - -
@sentry/react (incl. Tracing) 38.59 KB +0.05% +16 B 🔺
@sentry/vue 27.47 KB - -
@sentry/vue (incl. Tracing) 37.61 KB +0.05% +18 B 🔺
@sentry/svelte 23.43 KB - -
CDN Bundle 24.41 KB - -
CDN Bundle (incl. Tracing) 37.43 KB +0.07% +25 B 🔺
CDN Bundle (incl. Tracing, Replay) 72.62 KB +0.04% +24 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 77.98 KB +0.03% +21 B 🔺
CDN Bundle - uncompressed 71.69 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.99 KB +0.02% +20 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.06 KB +0.01% +20 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.28 KB +0.01% +20 B 🔺
@sentry/nextjs (client) 38.88 KB +0.06% +20 B 🔺
@sentry/sveltekit (client) 36.27 KB +0.05% +18 B 🔺
@sentry/node 163.73 KB - -
@sentry/node - without tracing 99.88 KB - -
@sentry/aws-serverless 127.38 KB - -

View base workflow run

@mydea mydea force-pushed the fn/browserMetricsTypes branch 3 times, most recently from cfe8689 to 4a72b76 Compare December 6, 2024 09:02
@mydea mydea marked this pull request as ready for review December 6, 2024 09:54
@mydea mydea requested review from AbhiPrasad and Lms24 December 6, 2024 09:54
@mydea mydea force-pushed the fn/browserMetricsTypes branch from 9619d44 to 024dd24 Compare December 10, 2024 08:15
@mydea mydea merged commit 71a5a7b into develop Dec 11, 2024
123 checks passed
@mydea mydea deleted the fn/browserMetricsTypes branch December 11, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydea @Lms24 @AbhiPrasad