Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(feeback): Handle css correctly in screenshot mode #14535

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix(feeback): Handle css correctly in screenshot mode #14535

merged 1 commit into from
Dec 2, 2024
+19 −8

Conversation

chargome
Copy link
Member

closes #14517

related to #14355

Updated version:

Screenshot 2024-11-29 at 21 20 35 Screenshot 2024-11-29 at 21 20 48 Screenshot 2024-11-29 at 21 21 16

@chargome chargome self-assigned this Nov 29, 2024
@chargome chargome requested a review from a team as a code owner November 29, 2024 20:25
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.1 KB - -
@sentry/browser - with treeshaking flags 21.83 KB - -
@sentry/browser (incl. Tracing) 35.5 KB - -
@sentry/browser (incl. Tracing, Replay) 72.39 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.87 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.71 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.19 KB +0.03% +27 B 🔺
@sentry/browser (incl. Feedback) 39.86 KB +0.06% +24 B 🔺
@sentry/browser (incl. sendFeedback) 27.72 KB - -
@sentry/browser (incl. FeedbackAsync) 32.53 KB - -
@sentry/react 25.8 KB - -
@sentry/react (incl. Tracing) 38.4 KB - -
@sentry/vue 27.25 KB - -
@sentry/vue (incl. Tracing) 37.3 KB - -
@sentry/svelte 23.25 KB - -
CDN Bundle 24.32 KB - -
CDN Bundle (incl. Tracing) 37.2 KB - -
CDN Bundle (incl. Tracing, Replay) 72.08 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.41 KB - -
CDN Bundle - uncompressed 71.45 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.5 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.57 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 236.79 KB - -
@sentry/nextjs (client) 38.71 KB - -
@sentry/sveltekit (client) 36.05 KB - -
@sentry/node 135.08 KB - -
@sentry/node - without tracing 97.13 KB - -
@sentry/aws-serverless 109.43 KB - -

View base workflow run

@chargome chargome merged commit 44477df into develop Dec 2, 2024
124 checks passed
@chargome chargome deleted the cg/fix-feedback-form-css branch December 2, 2024 08:31
@github-actions github-actions bot mentioned this pull request Dec 2, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@billyvg billyvg Awaiting requested review from billyvg

Assignees

@chargome chargome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentry form breaks after a screenshot attached
2 participants
@chargome @mydea