chore: Move pnpm version to root package.json & cleanup clean command
#14531
+22
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/update-clean-command
branch
from
bb4075b
to
86c2f76
Compare
Lms24
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that running
yarn cleanfrom the root hang for me sometimes, in two ways.On one hand, it seemed to hang/fail on running
pnpm store prunein the e2e-tests package. This PR fixes this by moving the pnpm dependency to the root of the monorepo, ensuring we have a consistent version for this and volta can properly set this up.On the other hand, it seemed to hang on watchman cleanup in node-integration-tests. I moved this up actually, and only run it in
clean:allas we don't really need this all that often.Finally, I also aligned the used rimraf version across the monorepo to 5.0.10.