feat(nuxt): Deprecate tracingOptions in favor of vueIntegration
#14530
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
size-limit report 📦
|
mydea
approved these changes
Nov 29, 2024
|
l: The changelog and the PR title reference nuxt, but the change is in the vue package? |
Good point actually. I seem to have fumbled that deprecation before - we already have it in the migration guide. Now it is actually correct. |
s1gr1d
reviewed
Nov 29, 2024
| /** | ||
| * @deprecated Add the `vueIntegration()` and pass the `tracingOptions` there instead. | ||
| */ | ||
| tracingOptions: Partial<TracingOptions>; |
There was a problem hiding this comment.
Looks good but same concern as here: https://github.com/getsentry/sentry-javascript/pull/14526/files#r1863577094
Base automatically changed from
lforst-expose-vue-integration-in-nuxt
to
develop
December 2, 2024 08:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #14265
Deprecates the
tracingOptionsin favor of the newly exposedvueIntegrationso that we can streamline the setting of these options.