chore: Dedupe @sentry/core imports
#14529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/dedupe-imports
branch
from
8535b91
to
05c4fcf
Compare
size-limit report 📦
|
chargome
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Shouldn't https://eslint.org/docs/latest/rules/no-duplicate-imports catch this?
I think we are not using this and are instead using something from biome there which does not seem to properly work (??) but not quite sure 😬 What I can say is that as of now it does not seem to actually do/check this xD |
Lms24
approved these changes
Nov 29, 2024
mydea
force-pushed
the
fn/dedupe-imports
branch
from
eda9e70
to
66d838d
Compare
I noticed we have a whole bunch of files that have multiple imports from `@sentry/core`, so I went over all of those I could find and ran VSCode auto-import-ordering to clean this up. Would be nice to have this taken care of by eslint/biome, but somehow this does not seem to work... :(
mydea
force-pushed
the
fn/dedupe-imports
branch
from
66d838d
to
8cea1da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we have a whole bunch of files that have multiple imports from
@sentry/core, so I went over all of those I could find and ran VSCode auto-import-ordering to clean this up. Would be nice to have this taken care of by eslint/biome, but somehow this does not seem to work... :(This for sure does not capture everything, but a good amount of duplication at least.