Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): Deprecate @sentry/types in favor of @sentry/core #14523

Merged
merged 10 commits into from
Nov 28, 2024
Merged

feat(types): Deprecate @sentry/types in favor of @sentry/core #14523

merged 10 commits into from
Nov 28, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Nov 28, 2024

Ref #14271

This deprecates @sentry/types in favor of @sentry/core.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited
Loading

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.12 KB - -
@sentry/browser - with treeshaking flags 21.82 KB - -
@sentry/browser (incl. Tracing) 35.53 KB - -
@sentry/browser (incl. Tracing, Replay) 72.44 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.81 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.76 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.22 KB - -
@sentry/browser (incl. Feedback) 39.86 KB - -
@sentry/browser (incl. sendFeedback) 27.74 KB - -
@sentry/browser (incl. FeedbackAsync) 32.54 KB - -
@sentry/react 25.79 KB - -
@sentry/react (incl. Tracing) 38.37 KB - -
@sentry/vue 27.27 KB - -
@sentry/vue (incl. Tracing) 37.33 KB - -
@sentry/svelte 23.27 KB - -
CDN Bundle 24.31 KB - -
CDN Bundle (incl. Tracing) 37.19 KB - -
CDN Bundle (incl. Tracing, Replay) 72.06 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.4 KB - -
CDN Bundle - uncompressed 71.42 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.47 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.54 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 236.76 KB - -
@sentry/nextjs (client) 38.69 KB - -
@sentry/sveltekit (client) 36.05 KB - -
@sentry/node 135.06 KB - -
@sentry/node - without tracing 97.11 KB - -
@sentry/aws-serverless 109.41 KB - -

View base workflow run

AbhiPrasad
AbhiPrasad approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope an LLM did this for you

@lforst
Copy link
Member Author

lforst commented Nov 28, 2024

I hope an LLM did this for you

I know my way around VS Code shortcuts 😎👉👉

Base automatically changed from lforst-hoist-types to develop November 28, 2024 15:40
@lforst lforst requested review from a team as code owners November 28, 2024 15:40
An error occurred while trying to automatically change base from lforst-hoist-types to develop November 28, 2024 15:40
@lforst lforst merged commit bdbdcc8 into develop Nov 28, 2024
52 checks passed
@lforst lforst deleted the lforst-deprecate-types branch November 28, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @AbhiPrasad