Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(profiling-node): Bump node-gyp to 10.2.0 #14522

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore(profiling-node): Bump node-gyp to 10.2.0 #14522

wants to merge 1 commit into from
+118 −27

Conversation

onurtemizkan
Copy link
Collaborator

Bumps node-gyp to the latest, which supports Python versions >= 3.12.

AbhiPrasad
AbhiPrasad approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we were hesitant in doing this because it makes our python version not match what is on the main sentry repo.

@JonasBa are we fine to do this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onurtemizkan @AbhiPrasad