feat(browser): Attach virtual stack traces to HttpClient events.
#14515
+95
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/httpclient-fingerprints
branch
2 times, most recently
from
252e544
to
7597e64
Compare
❌ 29 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
onurtemizkan
force-pushed
the
onur/httpclient-fingerprints
branch
3 times, most recently
from
ed1f24d
to
21169f8
Compare
onurtemizkan
force-pushed
the
onur/httpclient-fingerprints
branch
from
21169f8
to
d58da1c
Compare
mydea
reviewed
Nov 28, 2024
| @@ -75,6 +85,7 @@ export function instrumentXHR(): void { | |||
| endTimestamp: timestampInSeconds() * 1000, | |||
| startTimestamp, | |||
| xhr: xhrOpenThisArg, | |||
| error: httpClientInstrumented ? virtualError : undefined, | |||
There was a problem hiding this comment.
m: Can we just directly attach the stackframe here, instead of passing the error around? then we can maybe just ignore these checks and simply always attach this here 🤔
There was a problem hiding this comment.
Yes, this made it work with ESM builds. Thanks!
onurtemizkan
force-pushed
the
onur/httpclient-fingerprints
branch
from
05e3351
to
c0b864a
Compare
lforst
reviewed
Nov 29, 2024
Comment on lines
58
to
59
| const virtualError = new Error(); | ||
| const virtualStackTrace = virtualError.stack; |
There was a problem hiding this comment.
It is relatively expensive for engines to compute stack traces. I wonder if we could change this a bit so we don't create stack traces every time fetch is called but only when we actually need it.
There was a problem hiding this comment.
Ok, passing a boolean whether the fetch/xhr instrumentations are triggered by HttpClient was flaky because of maybeInstrument, so passing the error itself in handler data under virtualError key (not to conflict with other integrations like Breadcrumbs that use error key) and creating the stacks inside HttpClient will hopefully give us a slight performance improvement. a7b89bc
onurtemizkan
force-pushed
the
onur/httpclient-fingerprints
branch
from
c0b864a
to
8929cd3
Compare
onurtemizkan
force-pushed
the
onur/httpclient-fingerprints
branch
from
8929cd3
to
a7b89bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #8353
Updated
fetchandxhrwrappers to pass virtual errors to theHttpClientintegration so we can group the events with the stack traces.It seems we can't create the virtual errors inside the
HttpClientintegration, as we're losing the non-Sentry frames.Sampled fetch event - Link
Sampled XHR event - Link