ref(node): Avoid using propagator for node-fetch TWP instrumentation #14509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Nov 27, 2024
size-limit report 📦
|
AbhiPrasad
approved these changes
Nov 27, 2024
mydea
force-pushed
the
fn/fetch-propagate
branch
from
d37d542
to
13ee28c
Compare
Lms24
approved these changes
Nov 27, 2024
Instead, use the new and improved `getTraceData` directly, which avoids URL issues etc. and just gets the trace data.
mydea
force-pushed
the
fn/fetch-propagate
branch
from
d10280b
to
b4d2e58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, use the new and improved
getTraceDatadirectly, which avoids URL issues etc. and just gets the trace data.This also deprecates
generateSpanContextForPropagationContextand inlines it to the one place we still use this for, I'll probably adapt this in a follow up PR.