feat(remix): Deprecate autoInstrumentRemix: false
#14508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMHO we should not deprecate it, as setting this to |
lforst
changed the title
autoInstrumentRemixautoInstrumentRemix: false
This PR technically only deprecates setting it to false. This is the best we can currently do I think. |
|
I guess we should recommend setting this option to true in case it is currently set to false. |
AbhiPrasad
approved these changes
Nov 27, 2024
onurtemizkan
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14507
autoInstrumentRemixwill be removed in v9 in favor of a coherent unified instrumentation experience OOTB.