test(browser): Add integration test for changing transaction name in beforeSendTransaction
#14495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`beforeSendTransaction`
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Lms24
requested review from
a team,
lforst,
chargome and
s1gr1d
and removed request for
a team
lforst
approved these changes
Nov 27, 2024
chargome
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in an internal conversation: Some users need to update the transcation name in
beforeSendTransaction. While we strictly recommend changing the root span/transaction name as early as possible, it should nevertheless be possible at the end of the root span lifecycle, too.This test demonstrates that this works but it also shows "unexpected" behaviour: Despite users setting an explicit source in
beforeSendTransaction, we overwrite the source to'custom'. There's good reason for this in general: Changing the name of something the SDK previously identified as sourceurlorrouteshould be reflected by the source. But we don't account for the case where users explicitly set the source.For the moment though, this not an actual problem because
sourcesrouteandcustomare treated equally by Relay.