Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(profiling): Make prune script compatible with node 22 #14491

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix(profiling): Make prune script compatible with node 22 #14491

wants to merge 4 commits into from
+6 −1

Conversation

chargome
Copy link
Member

This pr just adds the ABI mapping for node 22 in the prune script.

(hopefully) closes #14488

@chargome chargome self-assigned this Nov 26, 2024
@JonasBa
Copy link
Member

JonasBa commented Nov 27, 2024

Thank you @chargome

@chargome chargome marked this pull request as ready for review November 28, 2024 13:38
AbhiPrasad
AbhiPrasad approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test to make sure this doesn't slip up in the future? We can do it in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@JonasBa JonasBa JonasBa approved these changes

Assignees

@chargome chargome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sentry-prune-profiler-binaries does not recognize NodeJS 22 as a valid major node version
3 participants
@chargome @JonasBa @AbhiPrasad