Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): Add openTelemetryInstrumentations option #14484

Merged
merged 2 commits into from
Nov 27, 2024
Merged

feat(node): Add openTelemetryInstrumentations option #14484

merged 2 commits into from
Nov 27, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Nov 26, 2024

Ref: #14483

This adds an option openTelemetryInstrumentations to the node init and Node client that can be used in the future to migrate away from addOpenTelemetryInstrumentation which is a bit foot-gunny timing wise with ESM instrumentation hooks.

@lforst lforst mentioned this pull request Nov 26, 2024
Closed
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.1 KB - -
@sentry/browser - with treeshaking flags 21.81 KB - -
@sentry/browser (incl. Tracing) 35.68 KB - -
@sentry/browser (incl. Tracing, Replay) 72.57 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.97 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.89 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.35 KB - -
@sentry/browser (incl. Feedback) 39.83 KB - -
@sentry/browser (incl. sendFeedback) 27.72 KB - -
@sentry/browser (incl. FeedbackAsync) 32.5 KB - -
@sentry/react 25.78 KB - -
@sentry/react (incl. Tracing) 38.5 KB - -
@sentry/vue 27.27 KB - -
@sentry/vue (incl. Tracing) 37.49 KB - -
@sentry/svelte 23.25 KB - -
CDN Bundle 24.28 KB - -
CDN Bundle (incl. Tracing) 37.3 KB - -
CDN Bundle (incl. Tracing, Replay) 72.19 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.53 KB - -
CDN Bundle - uncompressed 71.35 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.67 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.74 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 236.96 KB - -
@sentry/nextjs (client) 38.83 KB - -
@sentry/sveltekit (client) 36.18 KB - -
@sentry/node 134.94 KB +0.12% +155 B 🔺
@sentry/node - without tracing 96.77 KB +0.17% +160 B 🔺
@sentry/aws-serverless 106.96 KB +0.13% +140 B 🔺

View base workflow run

@lforst lforst requested review from mydea and timfish November 26, 2024 13:29
@lforst lforst merged commit 09a31d1 into develop Nov 27, 2024
134 checks passed
@lforst lforst deleted the lforst-add-otelinstrumentations-option branch November 27, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@timfish timfish timfish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lforst @timfish @mydea