Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nuxt): Remove nft override to ensure we are testing with latest nitro #14480

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

andreiborza
Copy link
Member

Noticed that our e2e tests are not actually using nitro 2.10 despite being on the latest nuxt version: https://github.com/getsentry/sentry-javascript/actions/runs/12028119465/job/33531969920#step:13:196

This fixes it.

@andreiborza andreiborza changed the title chore(nuxt): Upgrade nuxt version in e2e test to ensure we run with nitro 2.10 chore(nuxt): Remove nft override to ensure we are testing with latest nitro Nov 26, 2024
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)
Please also change the nuxt version "nuxt": "^3.13.1" to ^3.14.0 to make sure the dependencies are correctly added. As 3.14 adds a min. required dependency for nitro 2.10 (which includes the correct version for nft)

@andreiborza andreiborza merged commit 1d32374 into develop Nov 26, 2024
122 of 123 checks passed
@andreiborza andreiborza deleted the ab/e2e-nuxt-nitro-2.10-fix branch November 26, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants