Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(core): Do not check baggage validity #14479

Merged
merged 2 commits into from
Nov 27, 2024
Merged

ref(core): Do not check baggage validity #14479

merged 2 commits into from
Nov 27, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 26, 2024 •
edited
Loading

This PR drops the validation for baggage content. We didn't do this for browser previously, only for node, but it adds bundle size and does not appear too important.

I left the trace header validation in for now, we may also drop this but it is smaller and I guess also more important to us...?

@mydea mydea self-assigned this Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.1 KB - -
@sentry/browser - with treeshaking flags 21.81 KB - -
@sentry/browser (incl. Tracing) 35.51 KB -0.48% -174 B 🔽
@sentry/browser (incl. Tracing, Replay) 72.41 KB -0.23% -166 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.81 KB -0.26% -163 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 76.73 KB -0.22% -167 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 89.18 KB -0.19% -167 B 🔽
@sentry/browser (incl. Feedback) 39.83 KB - -
@sentry/browser (incl. sendFeedback) 27.72 KB - -
@sentry/browser (incl. FeedbackAsync) 32.5 KB - -
@sentry/react 25.78 KB - -
@sentry/react (incl. Tracing) 38.34 KB -0.41% -158 B 🔽
@sentry/vue 27.27 KB - -
@sentry/vue (incl. Tracing) 37.33 KB -0.43% -163 B 🔽
@sentry/svelte 23.25 KB - -
CDN Bundle 24.28 KB - -
CDN Bundle (incl. Tracing) 37.15 KB -0.41% -153 B 🔽
CDN Bundle (incl. Tracing, Replay) 72.05 KB -0.2% -147 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 77.39 KB -0.19% -147 B 🔽
CDN Bundle - uncompressed 71.35 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.38 KB -0.27% -296 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.45 KB -0.13% -296 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 236.67 KB -0.13% -296 B 🔽
@sentry/nextjs (client) 38.68 KB -0.39% -154 B 🔽
@sentry/sveltekit (client) 36.03 KB -0.44% -162 B 🔽
@sentry/node 134.79 KB - -
@sentry/node - without tracing 96.62 KB - -
@sentry/aws-serverless 106.83 KB +0.01% +1 B 🔺

View base workflow run

@mydea mydea requested review from Lms24 and lforst November 26, 2024 12:45
@mydea mydea marked this pull request as ready for review November 26, 2024 12:45
Lms24
Lms24 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: I think it's also fine to drop the sentry-trace validity check then

@mydea
Copy link
Member Author

mydea commented Nov 27, 2024

l: I think it's also fine to drop the sentry-trace validity check then

We may do that in a follow up I'd say, this way it's easier to see the impact (bundle size, ...) of each check :)

@mydea mydea merged commit 1e0cb04 into develop Nov 27, 2024
152 checks passed
@mydea mydea deleted the fn/getTraceDataValidation branch November 27, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @Lms24