ref: Refactor some any
#14477
Merged
ref: Refactor some any
#14477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
force-pushed
the
fn/refactor-some-any
branch
3 times, most recently
from
ca3b2e3
to
9b73900
Compare
mydea
commented
Nov 29, 2024
| @@ -211,8 +211,7 @@ export function addContextToFrame(lines: string[], frame: StackFrame, linesOfCon | |||
| * @returns `true` if the exception has already been captured, `false` if not (with the side effect of marking it seen) | |||
| */ | |||
| export function checkOrSetAlreadyCaught(exception: unknown): boolean { | |||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access | |||
| if (exception && (exception as any).__sentry_captured__) { | |||
| if (isAlreadyCaptured(exception)) { | |||
There was a problem hiding this comment.
This was unsafe because you could pass e.g. undefined here which would throw.
lforst
approved these changes
Nov 29, 2024
mydea
force-pushed
the
fn/refactor-some-any
branch
from
7eeeb4e
to
7353c1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring some
as anytype casts we have to avoid this.