ref(google-cloud-serverless/v9): Update event functions to avoid any
#14476
+17
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
reviewed
Nov 28, 2024
There was a problem hiding this comment.
I gotta admit my concern with the function signature change wasn't the change from any to unknown for data but the change in the return value form any to void. However, TIL that TS doesn't complain about actually returning a value in a void return typed function. So technically we still should merge this only in v9 I guess. Anyway, thanks for extracting!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors google-cloud-serverless to avoid some
anyin types. Since these are kind-of public, although this is extremely unlikely to affect anybody (because we mostly replaceanywithunknownwhich should also accept anything, basically), we'll still only merge this for v9.Extracted out of #14463