Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

As far as I see we only have pinia tests in the vue-3 and nuxt-4 E2E test apps, so adding tests to one of these (probably vue-3?) sounds reasonable to me! Not sure if others (cc @onurtemizkan or @s1gr1d ) have other ideas for this.

@mydea, yes I also think that's reasonable (and easier) to add cases to e2e tests.

IMHO a new case here will be enough for this PR.

@sircharlo, please let me know if you have any issues running the E2E tests.

@onurtemizkan Thanks for the feedback! Ok, I'll continue where I had left off in that file then, as that's where I had started writing a test.

Would this be the correct way to access an attachment from the current scope? I couldn't find an easy way to access the global scope from the error.

  const scopeData = error?.sdkProcessingMetadata?.capturedSpanScope?.getScopeData();
  const stateAttachment = scopeData?.attachments?.find(attachment => attachment.filename.includes('pinia_state_'));

You can wait for an attachment envelope item like this:

function waitForAttachment(
  proxyServerName: string,
  callback: (attachment: AttachmentItem[1]) => Promise<boolean> | boolean,
): Promise<AttachmentItem[1]> {
  const timestamp = getNanosecondTimestamp();
  return new Promise((resolve, reject) => {
    waitForEnvelopeItem(
      proxyServerName,
      async envelopeItem => {
        if (envelopeItem[0].type === 'attachment') {
          const attachmentItem = envelopeItem[1] as AttachmentItem[1];
          if (await callback(attachmentItem)) {
            resolve(attachmentItem);
            return true;
          }
        }

        return false;
      },
      timestamp,
    ).catch(reject);
  });
}

And then use it like this:

const errorPromise = waitForError('vue-3', async errorEvent => {
    return errorEvent?.exception?.values?.[0].value === 'This is an error';
  });
const attachmentPromise = waitForAttachment('vue-3', async attachment => {
  return attachment = '...';
});

  await page.locator('#throw-error').click();

  const error = await errorPromise;
const attachment = await attachmentPromise;

expect(attachment).toEqual(...);