meta(nuxt): Require minimum Nuxt v3.7.0 #14473
Conversation
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
packages/nuxt/package.json
Outdated
| "nitropack": ">=2.10.0", | ||
| "ofetch": ">=1.4.0" |
There was a problem hiding this comment.
Hmm, can we do this? Does this not enforce users to specify this version in their own package.json, which they probably do not have? 🤔
There was a problem hiding this comment.
The user does not have to explicitly install it, it just makes sure the dependency tree has the correct version. But if there is a conflicting peer, users might have to install it before npm v6: https://docs.npmjs.com/cli/v10/configuring-npm/package-json#peerdependencies
There was a problem hiding this comment.
Hmm...probably it's better to just not include those peer deps, just to be sure. I'll add them to the docs and list them as a requirement.
This PR adds a minimum required version for the Nuxt SDK. Version 3.7.0 was selected because this version adds the possibility to set client source maps to
'hidden'(PR here).However, as the SDK relies on other versions as well (see below, at the bottom), those packages need to be manually bumped (in case the lock-file is not updated yet). Nuxt 3.7.0 at least supports the correct version range:
"nitropack": "^2.6.1"
"ofetch": "^1.3.3"
Above Nuxt v3.14.0, everything works out of the box, as the versions are already updated:
"nitropack": "^2.10.2"
"ofetch": "^1.4.1"
Minimum versions, the SDK relies on:
nitropack2.10.0: for the correct peerDependency of@vercel/nftofetch1.4.0: for being able to patch$fetch