Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(node): Add --import test to integration tests #14471

Merged
merged 2 commits into from
Nov 27, 2024
Merged

test(node): Add --import test to integration tests #14471

merged 2 commits into from
Nov 27, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Nov 25, 2024

We do test --import=instrument.mjs in our e2e tests but there was nothing in the Node integration tests so I added this.

@timfish timfish marked this pull request as ready for review November 25, 2024 19:12
Lms24
Lms24 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this test! Definitely valuable to have an integration test for this.

@AbhiPrasad AbhiPrasad merged commit 42d045c into develop Nov 27, 2024
42 checks passed
@AbhiPrasad AbhiPrasad deleted the timfish/test/node-instrument branch November 27, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timfish @Lms24 @AbhiPrasad