Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(browser): Avoid optional chaining #14457

Merged
merged 1 commit into from
Nov 25, 2024
Merged

ref(browser): Avoid optional chaining #14457

merged 1 commit into from
Nov 25, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 25, 2024

We apparently disabled the no-optional-chaining rule in browser-utils, which lead to us including this polyfill. Properly enforcing this rule should (hopefully?) reduce bundle size a bit.

@mydea mydea self-assigned this Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.01 KB - -
@sentry/browser - with treeshaking flags 21.72 KB - -
@sentry/browser (incl. Tracing) 35.43 KB -0.54% -194 B 🔽
@sentry/browser (incl. Tracing, Replay) 72.33 KB -0.1% -74 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.63 KB -0.09% -55 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 76.64 KB -0.08% -57 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 89.08 KB -0.1% -91 B 🔽
@sentry/browser (incl. Feedback) 39.75 KB - -
@sentry/browser (incl. sendFeedback) 27.64 KB - -
@sentry/browser (incl. FeedbackAsync) 32.43 KB - -
@sentry/react 25.71 KB - -
@sentry/react (incl. Tracing) 38.3 KB -0.48% -187 B 🔽
@sentry/vue 27.2 KB - -
@sentry/vue (incl. Tracing) 37.25 KB -0.48% -181 B 🔽
@sentry/svelte 23.18 KB - -
CDN Bundle 24.18 KB - -
CDN Bundle (incl. Tracing) 36.98 KB -0.57% -215 B 🔽
CDN Bundle (incl. Tracing, Replay) 71.88 KB -0.11% -76 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 77.23 KB -0.1% -77 B 🔽
CDN Bundle - uncompressed 71.15 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.97 KB -0.53% -596 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.04 KB -0.15% -321 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 236.25 KB -0.14% -321 B 🔽
@sentry/nextjs (client) 38.62 KB -0.22% -85 B 🔽
@sentry/sveltekit (client) 35.93 KB -0.53% -195 B 🔽
@sentry/node 134.63 KB -0.01% -1 B 🔽
@sentry/node - without tracing 96.47 KB - -
@sentry/aws-serverless 106.7 KB - -

View base workflow run

@mydea mydea marked this pull request as ready for review November 25, 2024 13:14
@mydea mydea requested review from Lms24 and lforst November 25, 2024 13:14
@mydea mydea merged commit 1a31ec4 into develop Nov 25, 2024
127 checks passed
@mydea mydea deleted the fn/no-optional-chaining branch November 25, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @lforst