Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Remove & streamline some debug logs #14456

Merged
merged 2 commits into from
Nov 26, 2024
Merged

ref: Remove & streamline some debug logs #14456

merged 2 commits into from
Nov 26, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 25, 2024

Streamline some debug logs, esp. also removing some debug logs around browser metrics, in favor of just having a generic log when we add measurements.

@mydea mydea self-assigned this Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.01 KB - -
@sentry/browser - with treeshaking flags 21.72 KB - -
@sentry/browser (incl. Tracing) 35.55 KB -0.19% -69 B 🔽
@sentry/browser (incl. Tracing, Replay) 72.32 KB -0.12% -82 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.69 KB +0.01% +6 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 76.63 KB -0.1% -72 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 89.11 KB -0.07% -60 B 🔽
@sentry/browser (incl. Feedback) 39.75 KB - -
@sentry/browser (incl. sendFeedback) 27.64 KB - -
@sentry/browser (incl. FeedbackAsync) 32.43 KB - -
@sentry/react 25.71 KB - -
@sentry/react (incl. Tracing) 38.41 KB -0.19% -72 B 🔽
@sentry/vue 27.2 KB - -
@sentry/vue (incl. Tracing) 37.36 KB -0.19% -69 B 🔽
@sentry/svelte 23.18 KB - -
CDN Bundle 24.18 KB - -
CDN Bundle (incl. Tracing) 37.2 KB +0.02% +7 B 🔺
CDN Bundle (incl. Tracing, Replay) 71.96 KB +0.01% +7 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 77.31 KB +0.02% +8 B 🔺
CDN Bundle - uncompressed 71.15 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.54 KB -0.01% -8 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.34 KB -0.01% -8 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 236.56 KB -0.01% -8 B 🔽
@sentry/nextjs (client) 38.63 KB -0.19% -73 B 🔽
@sentry/sveltekit (client) 36.06 KB -0.19% -70 B 🔽
@sentry/node 134.64 KB +0.01% +1 B 🔺
@sentry/node - without tracing 96.47 KB +0.01% +1 B 🔺
@sentry/aws-serverless 106.7 KB -0.01% -1 B 🔽

View base workflow run

@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
659 1 658 27
View the top 1 failed tests by shortest run time 
client-app-routing-instrumentation.test.ts Creates a navigation transaction for app router routes
Stack Traces | 30s run time 
client-app-routing-instrumentation.test.ts:19:5 Creates a navigation transaction for app router routes

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Lms24
Lms24 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mydea mydea marked this pull request as ready for review November 25, 2024 15:25
@mydea mydea merged commit fc1d986 into develop Nov 26, 2024
155 of 156 checks passed
@mydea mydea deleted the fn/cleanup-logs branch November 26, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @Lms24