Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Deprecate flatten #14454

Merged
merged 2 commits into from
Nov 25, 2024
Merged

feat(core): Deprecate flatten #14454

merged 2 commits into from
Nov 25, 2024
+47 −11

Conversation

andreiborza
Copy link
Member

@andreiborza andreiborza commented Nov 25, 2024 •
edited
Loading

Ref: #14267

From my investigation, redis does not actually support arrays/nested arrays for keys and ioredis is wrapping thinly over redis functions, but otel has any[] as one of their possible values for command line arguments so I opted for inlining the implementation and adding a note to use Array.flat in v9.

@andreiborza andreiborza mentioned this pull request Nov 25, 2024
Closed
13 tasks
chargome
chargome approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As discussed, we can skip testing the (copied) function here as this will be replaced in v9.

@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
657 1 656 29
View the top 1 failed tests by shortest run time 
integrations/ContextLines/noAddedLines/test.ts should not add source context lines to errors from script files
Stack Traces | 30s run time 
test.ts:6:11 should not add source context lines to errors from script files

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@andreiborza andreiborza merged commit 3742bd3 into develop Nov 25, 2024
150 of 152 checks passed
@andreiborza andreiborza deleted the ab/deprecate-flatten branch November 25, 2024 12:35
@lforst lforst mentioned this pull request Nov 25, 2024
Merged
lforst added a commit that referenced this pull request Nov 26, 2024
@lforst
meta: Backfill v9 migration guide items (#14459)
cf368b1 
Backfills items to the draft migration guide for v9 that we missed

- #14433
- #14454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chargome chargome chargome approved these changes

@lforst lforst Awaiting requested review from lforst

@mydea mydea Awaiting requested review from mydea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreiborza @chargome