feat(browser-utils): Update web-vitals to v4.2.4
#14439
Merged
+443
−375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Lms24
commented
Nov 22, 2024
Comment on lines
-35
to
-37
| // Used to store the interaction count after a bfcache restore, since p98 | ||
| // interaction latencies should only consider the current navigation. | ||
| const prevInteractionCount = 0; |
There was a problem hiding this comment.
this was extracted to the /lib/interaction.ts file
Lms24
force-pushed
the
lms/ref-update-web-vitals-lib
branch
from
2803e51
to
fa8a690
Compare
Lms24
force-pushed
the
lms/ref-update-web-vitals-lib
branch
from
eb4eeb4
to
e1eff2e
Compare
timfish
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the vendored
web-vitalslibrary from 3.5.2 to 4.2.4I haven't seen any changes of major concern for us but I think it makes a lot of sense to stay up to date. Especially considering that they seem to be working on a version 5.x already.
Some noteable
web-vitalschanges:Further changes from our end:
onHiddenutility function was NOT updated to 4.2.4 due to the new version no longer triggering correctly for Safari 12.1-14.0 (which we still support). More details in the code commentgetNavigationEntrysince ww 4.2.4 only returns the entry if theresponseStarttime value is plausible. This is a good change for the library but since we also use the function to create other spans and attributes, I opted to leave things as they are for these use cases by passing in the flag to skip the plausibility check. This seems to be primarily a problem with Safari, which reportsresponseStart: 0sometimes.WINDOW.documentwhichweb-vitalsassumes to be presentlongtaskto the array of available types in theobservefunction