Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): Add disableAnrDetectionForCallback function #14359

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

feat(node): Add disableAnrDetectionForCallback function #14359

wants to merge 7 commits into from
+45 −3

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Nov 19, 2024 

disableAnrDetectionForCallback(() => dialog.openSaveDialog());

Maybe this should just go in the Electron SDK?

I added it for Node because it may be useful outside of Electron and at least here it has access to some private variables and types.

@timfish timfish mentioned this pull request Nov 20, 2024
Open
@timfish timfish marked this pull request as ready for review November 20, 2024 03:48
AbhiPrasad
AbhiPrasad approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should namespace this under anr to control the export count a little, maybe something to think about for v9.

Exporting this seems fine to me.

@AbhiPrasad
Copy link
Member

Mind fixing the merge conflicts? We can merge this in after!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timfish @AbhiPrasad