Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): align Error Boundary componentStack typing with React.Err… #14327

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(react): align Error Boundary componentStack typing with React.Err… #14327

wants to merge 1 commit into from
+1 −1

Conversation

kunal-511
Copy link

@kunal-511 kunal-511 commented Nov 16, 2024 •
edited
Loading

…orInfo

Fixed ErrorBoundary componentStack type in @sentry/react to use React.ErrorInfo['componentStack']

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@andreiborza andreiborza mentioned this pull request Nov 18, 2024
Open
AbhiPrasad
AbhiPrasad reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for opening a PR!

This also involves changing ErrorBoundaryState as well as onReset lifecycle methods, which makes this a breaking change.

Let's revisit this when we start working on v9!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunal-511 @AbhiPrasad