Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flags): Add OpenFeature integration #14326

Open
wants to merge 8 commits into
base: ref-ff-launch-darkly-integration-abstraction
Choose a base branch
from
Open

feat(flags): Add OpenFeature integration #14326

wants to merge 8 commits into from
+349 −12

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Nov 15, 2024 •
edited by billyvg
Loading

Adds OpenFeature feature flag integration.

Depends on #14207 and #14326

@cmanallen cmanallen changed the base branch from develop to aliu/launch-darkly November 15, 2024 19:24
@cmanallen cmanallen requested review from a team as code owners November 15, 2024 19:24
@cmanallen cmanallen changed the base branch from aliu/launch-darkly to aliu/launch-darkly-integration November 15, 2024 19:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.9 KB added added
@sentry/browser - with treeshaking flags 21.61 KB added added
@sentry/browser (incl. Tracing) 35.45 KB added added
@sentry/browser (incl. Tracing, Replay) 72.14 KB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.46 KB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 76.44 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 88.92 KB added added
@sentry/browser (incl. Feedback) 39.64 KB added added
@sentry/browser (incl. sendFeedback) 27.54 KB added added
@sentry/browser (incl. FeedbackAsync) 32.34 KB added added
@sentry/react 25.6 KB added added
@sentry/react (incl. Tracing) 38.32 KB added added
@sentry/vue 27.07 KB added added
@sentry/vue (incl. Tracing) 37.27 KB added added
@sentry/svelte 23.05 KB added added
CDN Bundle 24.08 KB added added
CDN Bundle (incl. Tracing) 37.04 KB added added
CDN Bundle (incl. Tracing, Replay) 71.74 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 77.09 KB added added
CDN Bundle - uncompressed 71.03 KB added added
CDN Bundle (incl. Tracing) - uncompressed 110.25 KB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.78 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 236 KB added added
@sentry/nextjs (client) 38.43 KB added added
@sentry/sveltekit (client) 35.96 KB added added
@sentry/node 134.49 KB added added
@sentry/node - without tracing 96.33 KB added added
@sentry/aws-serverless 106.57 KB added added

@bruno-garcia bruno-garcia mentioned this pull request Nov 15, 2024
Open
6 tasks
@billyvg billyvg changed the base branch from aliu/launch-darkly-integration to ref-ff-launch-darkly-integration-abstraction November 19, 2024 20:40
@billyvg billyvg force-pushed the cmanallen/open-feature-integration branch 2 times, most recently from ec24cae to 863b402 Compare November 19, 2024 22:07
chargome
chargome approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

packages/browser/src/integrations/featureFlags/openfeature/integration.ts Show resolved Hide resolved
@billyvg billyvg force-pushed the ref-ff-launch-darkly-integration-abstraction branch 2 times, most recently from 39583db to 4195a8e Compare November 20, 2024 17:48
@billyvg billyvg force-pushed the cmanallen/open-feature-integration branch from b85269d to 62f2305 Compare November 20, 2024 17:49
@billyvg billyvg force-pushed the cmanallen/open-feature-integration branch from 62f2305 to afd4f78 Compare November 20, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg left review comments

@chargome chargome chargome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmanallen @billyvg @chargome