feat(nitro-utils): Export Rollup Plugin wrapServerEntryWithDynamicImport
#14176
Conversation
s1gr1d
force-pushed
the
sig/nitro-utils
branch
from
b7aba48
to
21d30b6
Compare
packages/nitro-utils/src/rollupPlugins/wrapServerEntryWithDynamicImport.ts
Outdated
Show resolved
Hide resolved
packages/nitro-utils/src/rollupPlugins/wrapServerEntryWithDynamicImport.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Just one question but otherwise good to go from my end! Full disclosure: I'm not completely familiar with the rollup plugin details but it looks fine from my perspective. I think the package is correctly configured to not be published or cause issues while publishing.
packages/nitro-utils/README.md
Outdated
| # Sentry Utilities for Nitro-based SDKs | ||
|
|
||
| [](https://www.npmjs.com/package/@sentry-internal/nitro-utils) | ||
| [](https://www.npmjs.com/package/@sentry-internal/nitro-utils) | ||
| [](https://www.npmjs.com/package/@sentry-internal/nitro-utils) |
There was a problem hiding this comment.
super-l: As long as we don't publish this package, these badges will yield a 404 but that's fine
packages/nitro-utils/package.json
Outdated
| "@sentry/core": "8.36.0", | ||
| "@sentry/types": "8.36.0", |
There was a problem hiding this comment.
m: Does this package actually depend on core and types? I didn't see an import in the source files.
There was a problem hiding this comment.
Nope, doesn't depend on either. Removed.
| export default makeNPMConfigVariants( | ||
| makeBaseNPMConfig({ |
There was a problem hiding this comment.
l: Maybe one more question: Do we need a CJS version of this or is ESM enough? If we don't need CJS, we can configure the build to only emit ESM. In this case, we should also adjust the exports in package.json
There was a problem hiding this comment.
ESM should be enough in Nitro 👍
s1gr1d
force-pushed
the
sig/nitro-utils
branch
2 times, most recently
from
3c908f4
to
73150d2
Compare
s1gr1d
force-pushed
the
sig/nitro-utils
branch
2 times, most recently
from
ab1ccb3
to
4063dee
Compare
andreiborza
force-pushed
the
sig/nitro-utils
branch
from
bd3b43b
to
53552cf
Compare
andreiborza
force-pushed
the
sig/nitro-utils
branch
2 times, most recently
from
9fc213e
to
9b1ceec
Compare
andreiborza
force-pushed
the
sig/nitro-utils
branch
from
9b1ceec
to
dcad00f
Compare
packages/nitro-utils/package.json
Outdated
| @@ -39,7 +39,6 @@ | |||
| "access": "public" | |||
| }, | |||
| "dependencies": { | |||
| "@sentry/types": "8.37.1", | |||
| "@sentry/utils": "8.37.1" | |||
There was a problem hiding this comment.
We might need @sentry/core here because of #14431
Co-authored-by: Andrei <[email protected]>
Creates an internal package
@sentry-internal/nitro-utilswhich exports the Rollup plugin which is currently used in SolidStart and Nuxt.