Skip to content

Conversation

@distantnative
Copy link
Member

@distantnative distantnative commented Feb 25, 2023

This PR …

Fixes

Breaking changes

None

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@distantnative distantnative added this to the 3.9.2 milestone Feb 25, 2023
@distantnative distantnative requested a review from a team February 25, 2023 11:46
@distantnative distantnative self-assigned this Feb 25, 2023
@distantnative distantnative force-pushed the fix/5020-optionsapi-nest branch from cc25e1e to 0df111b Compare February 25, 2023 11:46
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Member

@lukasbestle lukasbestle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's nice. Pretty non-invasive. 👍
Also a good refactoring of array_map(). Performance will be just slightly lower, but it's so much more readable.

@distantnative distantnative merged commit 1b757c5 into develop Feb 26, 2023
@distantnative distantnative deleted the fix/5020-optionsapi-nest branch February 26, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants