Skip to content

Fix alt attribute issue for asset() helper #5066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
distantnative merged 1 commit into from
Feb 25, 2023
Merged

Fix alt attribute issue for asset() helper #5066

distantnative merged 1 commit into from
Feb 25, 2023

Conversation

@afbora
Copy link
Member

@afbora afbora commented Feb 24, 2023 •
edited by distantnative
Loading

This PR …

Fixes #4915 regression with implementing the solution in #5065 (comment) of @lukasbestle

Fixes

Breaking changes

None

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@afbora afbora added this to the 3.9.2 milestone Feb 24, 2023
@afbora afbora self-assigned this Feb 24, 2023
@afbora afbora linked an issue Feb 24, 2023 that may be closed by this pull request
asset() helper breaks when using an image file since 3.9 #5065
Closed
@distantnative distantnative merged commit badbc6b into develop Feb 25, 2023
@distantnative distantnative deleted the fix/5065-asset-alt-attribute branch February 25, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@distantnative distantnative distantnative approved these changes

@lukasbestle lukasbestle Awaiting requested review from lukasbestle

Assignees

@afbora afbora

Labels

None yet

Milestone

3.9.2

Development

Successfully merging this pull request may close these issues.

asset() helper breaks when using an image file since 3.9

3 participants

@afbora @distantnative