Fix and improve the youtube embed helper #5059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
afbora
force-pushed
the
fix/5058-embed-helper
branch
from
d84f0b0 to
44b6459
Compare
lukasbestle
reviewed
Feb 18, 2023
Member
lukasbestle
left a comment
lukasbestle
left a comment
There was a problem hiding this comment.
Looks good to me. Could you please also add test cases for more doNotTrack variants with different URLs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
Fixes
doNotTrackargument in YouTube embed helper Embed helper doesn't respect DoNotTrack parameter on short Youtube URLs #5058Enhancements
Breaking changes
None
Ready?
For review team