-
-
Notifications
You must be signed in to change notification settings - Fork 186
Provide $field prop to block/layout objects
#5053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
distantnative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, one small comment
|
@lukasbestle @distantnative I think we need also implement the |
|
@afbora Those are part of the reason why the Edit: Forget what I wrote, I think it should actually be doable. Thanks for spotting! Do you have time to update the code? Otherwise let's move this to 3.9.3. |
Actually this is easy for first one but other two ones are a little complicated since that ones inherit Possible solutions in my mind:
Which way do we should follow? |
|
The goal of the new field prop is to make UUIDs for blocks possible in a future version. So I think we can't make it a form field, it needs to be a content field. |
afbora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added only for first one (content field) 👍
|
I've created a PR that fixes CI workflow issue #5055 |
dcc39c6 to
1802881
Compare
|
@afbora Thanks for updating the I checked the other two uses in |
|
So looks good to me. Maybe @distantnative can have a final look before we merge this. |
This PR …
Features
$block->field(),$layout->field()and$layoutColumn->field().Breaking changes
None
Ready?
For review team