Correct "Logout" menu label to "Log out" #5047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbora
force-pushed
the
rename-log-out
branch
from
d1bd6ec to
7d5a46a
Compare
afbora
force-pushed
the
rename-log-out
branch
from
7d5a46a to
74f1566
Compare
afbora
approved these changes
Feb 16, 2023
lukasbestle
approved these changes
Feb 17, 2023
Member
lukasbestle
left a comment
lukasbestle
left a comment
There was a problem hiding this comment.
Thanks for the fix!
@afbora When merging it we need to be careful to update the translations in Transifex like last time.
Member
|
@lukasbestle Yes, I or Bastian can take care it. |
Member
|
@bastianallgeier Did you push the change to transifex? (in order not to overlook) |
Member
|
I just did. It looks like Transifex was smart enough to use the old version. At least for German. Can you check if it also worked for Turkish? I think we need to double-check again before the release. |
Member
|
Yes, auto translated for Turkish language 👍 I'll check all languages now. |
Member
|
✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the menu label from "Logout" (noun) to "Log out" (verb).
(I should have picked this up in #4482 !)