Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed connecting to a remote cluster when pipeline.jars empty #73

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Fixed connecting to a remote cluster when pipeline.jars empty #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## [Unreleased]

### Fixed

- Fixed connecting to a remote cluster when `pipeline.jars` property is empty.

## [0.13.0] - 2023-01-17

### Added
Expand Down
2 changes: 1 addition & 1 deletion streaming_jupyter_integrations/magics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def _get_pipeline_jars(conf: Configuration) -> JavaArray:
# (org.apache.flink.api.java.RemoteEnvironmentConfigUtils#getJarFiles). On the other hand, jars specified in
# "pipeline.jars" have to contain the schema. Therefore, we need to remove the schema on our own.
gateway = get_gateway()
pipeline_jars = conf.get_string("pipeline.jars", "").split(";")
pipeline_jars = list(filter(lambda p: p, conf.get_string("pipeline.jars", "").split(";")))
result = gateway.new_array(gateway.jvm.String, len(pipeline_jars))
for i in range(len(pipeline_jars)):
result[i] = pipeline_jars[i].replace("file://", "")
Expand Down