Try to load flink-conf.yaml from FLINK_CONF_DIR first #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swtwsk
suggested changes
Dec 28, 2022
Contributor
swtwsk
left a comment
swtwsk
left a comment
There was a problem hiding this comment.
LGTM, but add few short tests for searching for the env vars and the file, please
andrzejdackiewicz
approved these changes
Dec 28, 2022
grzegorz8
force-pushed
the
try-to-read-flink-conf-from-flink-conf-dir
branch
from
0196222 to
36d2c72
Compare
niladrem
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.