Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning when element IDs match without special characters such as new lines #1388

Closed
JohnKomov opened this issue Feb 21, 2016 · 2 comments · Fixed by #2644
Closed

Add warning when element IDs match without special characters such as new lines #1388

JohnKomov opened this issue Feb 21, 2016 · 2 comments · Fixed by #2644
Assignees
@WaltonG
Labels
IO Wishlist New features (not a bug)
Milestone
0.10.0

Comments

@JohnKomov
Copy link

Hi. I found that 'JohnKomov' and 'JohnKomov\n' are the different names for merging code and the same ones for Gephi itself. The result of such duality is a Java Exception and two nodes with the same visible names and different sets of edges. Check out other non-alphabetical symbols too (I didn't check).
@mbastian
Copy link
Member

I'm sorry but that is a input issue. We don't want to introduce rules such as cleaning '\n' from input ids or labels as it could introduce confusion. However, it could be added as a "Warning" for instance in the import report.

@mbastian mbastian changed the title An unpleasant posibility with nodes' names Add warning when element IDs match without special characters such as new lines Apr 16, 2016
@mbastian mbastian added Wishlist New features (not a bug) IO labels Apr 16, 2016
@mbastian
Copy link
Member

We already have a import container validation step that is designed to iterate over all the elements and is capable of adding errors and warnings.

Definition of done

  • Add a new warning when element ids contain special characters.

The list of special characters is up for discussion. At the very list newline characters. Leading or trailing whitespaces might be nice as well.

@mbastian mbastian added this to the 0.10.0 milestone Aug 28, 2022
@mbastian mbastian moved this to In Progress in Gephi Retreat 2022 Sep 2, 2022
@mbastian mbastian linked a pull request Nov 9, 2022 that will close this issue
#1388 Warning of newline characters, leading and trailing spaces on elements id #2644
Merged
mbastian pushed a commit that referenced this issue Nov 11, 2022
@WaltonG
#1388 Warning of newline characters, leading and trailing spaces on e…
9fc3212 
…lements id (#2644)

* Check newline characters, leading and trailing space.

* Refactored checkSpecialCharacter function

* Added unit test

* Fix test and improve function

* Variable name

Co-authored-by: Walton Goga
Repository owner moved this from In Progress to Done in Gephi Retreat 2022 Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WaltonG WaltonG

Labels
IO Wishlist New features (not a bug)
Projects
No open projects
Gephi Retreat 2022
Status: Done
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

#1388 Warning of newline characters, leading and trailing spaces on elements id gephi/gephi
3 participants
@mbastian @JohnKomov @WaltonG