Skip to content

Conversation

@Arxa
Copy link
Contributor

@Arxa Arxa commented Oct 22, 2024

GEOT-7673 Powered by Pull Request Badge

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • There is an issue in GeoTools Jira (except for changes not visible to end users).
  • Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

@aaime
Copy link
Member

aaime commented Oct 23, 2024

While having an integration test in GeoServer is a good thing, we also need a unit test here. See the checklist above.

@jodygarnett
Copy link
Member

This looks good, as @aaime indicates I cannot merge with without a unit test

@mprins mprins added the backport 32.x Automatic backport to 32.x branch label Dec 16, 2024
@mprins mprins self-assigned this Dec 16, 2024
@mprins
Copy link
Member

mprins commented Dec 16, 2024

@jodygarnett @aaime I have rebased this PR and added a testcase

@mprins mprins added the backport 31.x Automatic backport to 31.x branch label Dec 16, 2024
@mprins mprins merged commit d1aaaff into geotools:main Dec 16, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 31.x Automatic backport to 31.x branch backport 32.x Automatic backport to 32.x branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants