[GEOS-11612] Add proxy base url use headers system property support#8042
Merged
aaime merged 1 commit intogeoserver:mainfrom Dec 9, 2024
Merged
[GEOS-11612] Add proxy base url use headers system property support#8042aaime merged 1 commit intogeoserver:mainfrom
aaime merged 1 commit intogeoserver:mainfrom
Conversation
aaime
requested changes
Nov 25, 2024
Member
aaime
left a comment
There was a problem hiding this comment.
Looks good, added a note about documentation, below:
Member
There was a problem hiding this comment.
Can you please update also the full list of system variables found at doc/en/user/source/configuration/properties/index.rst ?
Mind, best if you git rebase on main, that file just got updated, or you'll get a conflict.
Member
There was a problem hiding this comment.
Also state that using the property results in the GUI setting being ignored.
a2f0298 to
8521c67
Compare
Member
Author
|
Thanks @aaime for your review, I added the suggested documentation entries. |
8521c67 to
ad54e29
Compare
This was referenced Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, system property activation is supported for Proxy base URL setting on GeoServer, but there is no option to enable the Use Headers setting using the same approach. This task is focused on add the same flags support level in order to sync both features activation.
The proposed system property is on the example:
https://osgeo-org.atlassian.net/browse/GEOS-11612
Checklist
mainbranch (backports managed later; ignore for branch specific issues).For core and extension modules:
[GEOS-XYZWV] Title of the Jira ticket.