Skip to content

[GEOS-11612] Add proxy base url use headers system property support#8042

Merged
aaime merged 1 commit intogeoserver:mainfrom
fernandor777:proxy-base-header
Dec 9, 2024
Merged

[GEOS-11612] Add proxy base url use headers system property support#8042
aaime merged 1 commit intogeoserver:mainfrom
fernandor777:proxy-base-header

Conversation

@fernandor777
Copy link
Member

@fernandor777 fernandor777 commented Nov 19, 2024

GEOS-11612 Powered by Pull Request Badge

Currently, system property activation is supported for Proxy base URL setting on GeoServer, but there is no option to enable the Use Headers setting using the same approach. This task is focused on add the same flags support level in order to sync both features activation.

The proposed system property is on the example:

-DPROXY_BASE_URL_HEADERS=true

https://osgeo-org.atlassian.net/browse/GEOS-11612

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

@nmco nmco requested a review from aaime November 19, 2024 14:51
Copy link
Member

@aaime aaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added a note about documentation, below:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update also the full list of system variables found at doc/en/user/source/configuration/properties/index.rst ?

Mind, best if you git rebase on main, that file just got updated, or you'll get a conflict.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also state that using the property results in the GUI setting being ignored.

@fernandor777
Copy link
Member Author

Thanks @aaime for your review, I added the suggested documentation entries.

@randomorder randomorder requested a review from aaime December 6, 2024 09:30
@aaime aaime added backport 2.25.x Instructs the bot to create a 2.25.x backport PR on merge backport 2.26.x Instructs the bot to create a 2.26.x backport PR on merge labels Dec 9, 2024
Copy link
Member

@aaime aaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.25.x Instructs the bot to create a 2.25.x backport PR on merge backport 2.26.x Instructs the bot to create a 2.26.x backport PR on merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants