Add support for Python3.12 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achapkowski
reviewed
Nov 13, 2023
larsbutler
force-pushed
the
python-312-support
branch
2 times, most recently
from
bf9d4e0 to
b388333
Compare
larsbutler
force-pushed
the
python-312-support
branch
from
b388333 to
dae6c82
Compare
Indeed. I had forgotten about the tokenization change in Python 3.12, but seems like an easy fix (we just need to ignore some empty string tokens; not a significant change to the WKT parsing logic). |
|
I think we're good now. @achapkowski Do these changes look okay to you? |
achapkowski
approved these changes
Nov 14, 2023
|
Thanks @achapkowski! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92 and #104.