Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_dict fix for Recipient #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

to_dict fix for Recipient #19

wants to merge 1 commit into from

Conversation

navyad
Copy link
Contributor

@navyad navyad commented Aug 19, 2016 

In [23]: recp = Recipient(123, 345)

In [24]: recp.to_dict()
Out[24]: {'id': 123}

to_dict() , dictionary does not have phone_numbereven though instance has phone_number value

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.667% when pulling 10f3a60 on navyad:navyad/patch-4 into 9749e88 on geeknam:master.

@geeknam
Copy link
Owner

geeknam commented Aug 28, 2016

I recall the docs says ID is preferred over phone number. Happy to merge if you prove me wrong :P

@navyad
Copy link
Contributor Author

navyad commented Sep 2, 2016 •
edited
Loading

not sure about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@navyad @coveralls @geeknam