Modify cartoee.add_legend #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giswqs
reviewed
Mar 28, 2022
geemap/cartoee.py
Outdated
| @@ -1014,7 +1014,7 @@ def scale_number(x): | |||
| return | |||
|
|
|||
|
|
|||
| def add_legend(ax, legend_elements=None, loc="lower right"): | |||
| def add_legend(ax, legend_elements=None, loc="lower right",font_size=14, font_weight='normal',font_color='k',show_chinese=False): | |||
There was a problem hiding this comment.
Suggest changing the show_chinese=False argument to font_family=None
There was a problem hiding this comment.
font_color='k' should probably be font_color='black'. Readers won't know what k stands for.
giswqs
reviewed
Mar 28, 2022
geemap/cartoee.py
Outdated
| @@ -1044,8 +1047,16 @@ def add_legend(ax, legend_elements=None, loc="lower right"): | |||
| ls="", | |||
| ), | |||
| ] | |||
|
|
|||
| ax.legend(handles=legend_elements, loc=loc) | |||
| if show_chinese == True: | |||
There was a problem hiding this comment.
if font_family is not None:
fontdict={"family": font_family, "size": font_size, "weight": font_weight}
else:
fontdict={"size": font_size, "weight": font_weight}
giswqs
reviewed
Mar 28, 2022
geemap/cartoee.py
Outdated
| font_size(int|string, optional): Font size. Either an absolute font size or an relative value of 'xx-small', 'x-small', 'small', 'medium', 'large', 'x-large', 'xx-large'. defaults to 14. | ||
| font_weight(string|int, optional): Font weight. A numeric value in the range 0-1000 or one of 'ultralight', 'light', 'normal' (default), 'regular', 'book', 'medium', 'roman', 'semibold', 'demibold', 'demi', 'bold', 'heavy', 'extra bold', 'black'. Defaults to 'normal'. | ||
| font_color(str, optional): Text color. Defaults to "black". | ||
| show_chinese(bool, optional): Whether to display Chinese fonts. If True, using 'SimHei' font. |
There was a problem hiding this comment.
font_family (str, optional): The font family to use. It supports Chinese fonts, e.g., SimHei.
|
I have made some suggestions. Please make changes accordingly and commit changes to the PR. |
|
Looks good. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding font size, weight, color, and Chinese font support in cartoee.add_legend.