Skip to content

Migrating algorithms sub-package to ee_extra.#868

Merged
giswqs merged 5 commits intogee-community:masterfrom
csaybar:master
Jan 16, 2022
Merged

Migrating algorithms sub-package to ee_extra.#868
giswqs merged 5 commits intogee-community:masterfrom
csaybar:master

Conversation

@csaybar
Copy link
Collaborator

@csaybar csaybar commented Jan 16, 2022

Dear Prof. Quisheng Wu,

The river.py is already on ee_extra! 🚀. Once we add more algorithms, I'll keep maintaining and upgrading the bridge with geemap :)

example: https://colab.research.google.com/drive/1kPeVDNvIWCZYeI5nUWSeWeOmM85kh6NF
conda: https://anaconda.org/conda-forge/ee_extra
pip: https://pypi.org/project/ee-extra/

@csaybar csaybar changed the title Migrating algorithm sub-package to ee_extra. Migrating algorithms sub-package to ee_extra. Jan 16, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jan 16, 2022

This pull request fixes 1 alert when merging 4c1e45d into ba8de85 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported more than once

@giswqs
Copy link
Member

giswqs commented Jan 16, 2022

This is great. To minimize the maintain work you need to do, I think you can simply put the following line in __init__.py. The river.py is no longer needed. Whenever you add a new algorithm module to ee_extra, simply modify the following line to import the new module. What do you think?

from ee_extra.Algorithms import river, panSharpening # any new module should be imported here

@csaybar
Copy link
Collaborator Author

csaybar commented Jan 16, 2022

I think that would be better :D. I make a commit with the required changes. :)

@giswqs giswqs merged commit 6cd7522 into gee-community:master Jan 16, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jan 16, 2022

This pull request fixes 1 alert when merging b141108 into ba8de85 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported more than once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants