The hover for countries didn't work #686
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature['id'] doesn't work for ids of countries now, the data has been changed for it. It works with the given change I did.
Member
|
Good catch. Could you also update the notebook under the docs folder? |
Contributor
Author
Sure! |
Shweta200126
added a commit
to Shweta200126/geemap
that referenced
this pull request
Sep 23, 2021
Fixes: gee-community#686 pull-request follow-up
Merged
While doing the follow up to the original pull request, I realised that I didn't make the right changes here. This is the correct change to that and checked as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature['id'] doesn't work for ids of countries now, the data has been changed for it in data/countries.geojson.
It works with the given change did here i.e. feature['properties']['ISO_A2'] or we can use feature['properties']['ISO_A3'], both gives us the id for the country.
Before:
After:
https://watch.screencastify.com/v/ACkAlAVTpP4ZUQ2R0A7F