Fix several bugs and add basemap selector to core.#1735
Merged
Conversation
Contributor
|
🚀 Deployed on https://6514f8cf1cde0744a6c8b3c4--opengeos.netlify.app |
Member
Member
Collaborator
Author
Member
Member
|
Never mind. I figured it out. I am on a travel laptop. Forgot to use |
Member
Member
|
Just discovered another bug. The Screen.Recording.2023-09-27.at.11.16.27.PM.mov |
giswqs
reviewed
Sep 28, 2023
geemap/core.py
Outdated
| ipyleaflet.TileLayer( | ||
| url=basemap["url"], | ||
| name=basemap["name"], | ||
| max_zoom=basemap.get("max_zoom", 22), |
Member
|
This seems an unexpect behavior (or maybe a bug) of ipyleaflet. When there is only one layer on the map, import ipyleaflet
m = ipyleaflet.Map(center=(0, 0), zoom=2)
m.remove_layer(m.layers[0]) # not working
m.clear_layers() # working |
Collaborator
Author
|
Thanks for finding these issues. Looking into them now. |
Member
|
Thanks for the quick fix. It works now. |
giswqs
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





The basemap selector for geemap should be unchanged.
The basemap selector for core actually swaps out
layer[0]. Users can manually add additional basemap layers if they choose.